Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out push notif and Fix empty daily rounds design #6710

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

Ashesh3
Copy link
Contributor

@Ashesh3 Ashesh3 commented Nov 24, 2023

WHAT

🤖[deprecated] Generated by Copilot at 1fe5b48

Filter out PUSH_MESSAGE notifications from the notifications list component. This prevents showing duplicate notifications for the same push message that is also shown in the toast component.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖[deprecated] Generated by Copilot at 1fe5b48

  • Filter out notifications with event type "PUSH_MESSAGE" from the notifications list to avoid duplicates (link)

@Ashesh3 Ashesh3 requested a review from a team November 24, 2023 14:26
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 24, 2023 14:26
@Ashesh3 Ashesh3 requested a review from vigneshhari November 24, 2023 14:26
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 2:55pm

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bc5b93b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6560b929cc936700081ae861
😎 Deploy Preview https://deploy-preview-6710--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashesh3 Ashesh3 changed the title Filter out PUSH_MESSAGE notifications in Filter out PUSH_MESSAGE notifications Nov 24, 2023
Copy link

cypress bot commented Nov 24, 2023

Passing run #1617 ↗︎

0 85 0 0 Flakiness 0

Details:

Filter out push notif and Fix empty daily rounds design
Project: CARE Commit: bc5b93bcc9
Status: Passed Duration: 02:15 💡
Started: Nov 24, 2023 2:58 PM Ended: Nov 24, 2023 3:00 PM

Review all test suite changes for PR #6710 ↗︎

@Ashesh3 Ashesh3 changed the title Filter out PUSH_MESSAGE notifications Filter out push notif and Fix empty daily rounds design Nov 24, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit ba2c91d into develop Nov 24, 2023
@khavinshankar khavinshankar deleted the filter-webpush branch November 24, 2023 15:03
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants