Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live update socket URL on middleware hostname change in Asset Configure #7149

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Live update socket URL on middleware hostname change in Asset Configure #7149

merged 1 commit into from
Feb 7, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Feb 1, 2024 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner February 1, 2024 13:52
@netlify Netlify
Copy link

netlify bot commented Feb 1, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3b3d749
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65bba224383c6800080969ce
😎 Deploy Preview https://deploy-preview-7149--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 1:52pm

@rithviknishad rithviknishad requested a review from Ashesh3 February 1, 2024 13:52
@cypress Cypress
Copy link

cypress bot commented Feb 1, 2024

Passing run #2009 ↗︎

0 102 0 0 Flakiness 0

Details:

Live update socket URL on middleware hostname change in Asset Configure
Project: CARE Commit: 3b3d749840
Status: Passed Duration: 02:29 💡
Started: Feb 1, 2024 1:56 PM Ended: Feb 1, 2024 1:58 PM

Review all test suite changes for PR #7149 ↗︎

@nihal467
Copy link
Member

nihal467 commented Feb 4, 2024

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member needs review and removed needs testing needs review reviewed reviewed by a core member labels Feb 4, 2024
@khavinshankar khavinshankar merged commit fd53e5e into develop Feb 7, 2024
66 checks passed
@khavinshankar khavinshankar deleted the fix-hl7-configure-middleware-state branch February 7, 2024 05:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vital monitor middleware state is not getting reset post updation
4 participants
@rithviknishad @nihal467 @Ashesh3 @khavinshankar