Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional units and route to prescriptions #8075

Merged

Conversation

cu8code
Copy link
Contributor

@cu8code cu8code commented Jun 22, 2024

Required Backends

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@cu8code cu8code requested a review from a team as a code owner June 22, 2024 21:16
Copy link

vercel bot commented Jun 22, 2024

@cu8code is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 768fc61
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6687d128568d0700089624f6
😎 Deploy Preview https://deploy-preview-8075--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Jun 26, 2024

image
image

  • the PR is not allowing the user to create a medicine in mcg and unit dose or the newly added route is not selectable. Make necessary backend changes and mention the PR along with this PR for review purposes.

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
@cu8code
Copy link
Contributor Author

cu8code commented Jun 26, 2024

thanks for the review @nihal467 and remark i will make the needed changes

@aparnacoronasafe
Copy link
Member

@nihal467 in dosage "unit" also needs to be added in the dropdown. As per the issue

@aparnacoronasafe
Copy link
Member

@cu8code please bring this to a closure. Hoping to see this go to production on Monday

@aparnacoronasafe aparnacoronasafe added the P1 breaking issue or vital feature label Jul 5, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 5, 2024

@cu8code Due to inactivity I am closing this non-functional PR and assigning this issue to @rithviknishad its been escalated to P1 priority

@nihal467 nihal467 closed this Jul 5, 2024
@rithviknishad rithviknishad changed the title Add mcg as new dosage unit; Add Sublingual; Add additional units and route to prescriptions Jul 5, 2024
@rithviknishad rithviknishad reopened this Jul 5, 2024
@rithviknishad rithviknishad changed the title Add additional units and route to prescriptions Adds additional units and route to prescriptions Jul 5, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 8, 2024

LGTM

@khavinshankar khavinshankar merged commit 36e156f into ohcnetwork:develop Jul 9, 2024
35 of 36 checks passed
Copy link

github-actions bot commented Jul 9, 2024

@cu8code Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prescription - improvement to dropdown
5 participants