-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 'CONSULTATION NOTES' to 'GENERAL INSTRUCTIONS (ADVICE)' #8216
Changes 'CONSULTATION NOTES' to 'GENERAL INSTRUCTIONS (ADVICE)' #8216
Conversation
@ahmedobaid23 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice attempt!
Although this works, there would be other keys
that might need an altered display text eventually.
Consider adding a map or using translation files (preferred) to reverse the key to a display text.
For example, refer:
Thanks for reviewing my PR. I will create a new file named |
You can keep it in consultation.json itself. We have all consultation related translation keys present there. |
interface IProps { | ||
values: Record<string, unknown>; | ||
} | ||
|
||
type ConsultationMessageKeys = keyof typeof consultationMessage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't be importing the translations file directly. Use useTranslation
hook to retrieve the display text instead. Ref: https://github.com/coronasafe/care_fe/blob/f76248c997c1153a9f859511a6678ada18dd0af9/src/Components/Facility/Consultations/DailyRoundsList.tsx#L24
👋 Hi, @ahmedobaid23, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@ahmedobaid23 can you work on the changes requested |
@rithviknishad Yes, I am working on it |
LGTM |
@ahmedobaid23 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist