Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the fine text in Patient transfer pop-up to match with recent change #8344

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Modified the fine text in Patient transfer pop-up to match with recent change #8344

merged 2 commits into from
Aug 21, 2024

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Aug 19, 2024 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nihal467 nihal467 requested a review from a team as a code owner August 19, 2024 08:44
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 0:06am

@nihal467 nihal467 linked an issue Aug 19, 2024 that may be closed by this pull request
Year of birth : patient transfer pop-up #8341
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d5bc952
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c4868c144f140009c48791
😎 Deploy Preview https://deploy-preview-8344--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Aug 19, 2024 •
edited
Loading


Test summary

126 • 0 • 0 • 0

Run details
Project CARE
Status Passed
Commit d5bc952
Started Aug 20, 2024 12:10 PM
Ended Aug 20, 2024 12:13 PM
Duration 03:00 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

rithviknishad
rithviknishad requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihal467 Can we keep the texts in i18n files instead?

@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Aug 20, 2024
@khavinshankar khavinshankar merged commit dc9f3c0 into develop Aug 21, 2024
62 of 63 checks passed
@khavinshankar khavinshankar deleted the fix-warningmessage branch August 21, 2024 04:43
@github-actions GitHub Actions
Copy link

@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Year of birth : patient transfer pop-up
3 participants
@nihal467 @rithviknishad @khavinshankar