Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made General Instructions field in Consultation Form non mandatory #8368

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

JOSHIK27
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@JOSHIK27 JOSHIK27 requested a review from a team as a code owner August 20, 2024 13:35
Copy link

vercel bot commented Aug 20, 2024

@JOSHIK27 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 13b53b5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c5be599d87160008bc70b7
😎 Deploy Preview https://deploy-preview-8368--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JOSHIK27 could you discard changes from your other PR being present here?

Treating physician required condition is not relevant to the linked issue of this PR right.

Other than that, LGTM

@JOSHIK27
Copy link
Contributor Author

JOSHIK27 commented Aug 20, 2024

@JOSHIK27 could you discard changes from your other PR being present here?

Treating physician required condition is not relevant to the linked issue of this PR right.

Other than that, LGTM

Makes sense.

[Edited]
Updated the code. Hope it is as expected @rithviknishad

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a65681e into ohcnetwork:develop Aug 21, 2024
29 of 30 checks passed
Copy link

@JOSHIK27 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General instructions (advice): consultation
4 participants