Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clear all filters when no filters are applied. #8466

Conversation

Sulochan-khadka
Copy link
Contributor

… Discharge patients page #8449

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner September 3, 2024 07:12
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 29d2778
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66daa44002625e00088c58ce
😎 Deploy Preview https://deploy-preview-8466--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right. Now when I apply consent record filters, the badges appear however, the clear all filters button doesn't.

image

@Sulochan-khadka
Copy link
Contributor Author

This is not right. Now when I apply consent record filters, the badges appear however, the clear all filters button doesn't.

image

Apologies for the oversight. I hope that the issue has been fixed in the update.

@nihal467
Copy link
Member

nihal467 commented Sep 6, 2024

LGTM

@khavinshankar khavinshankar merged commit 7769eb9 into ohcnetwork:develop Sep 10, 2024
23 checks passed
Copy link

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show clear all filters button if there is no filter applied in Discharge patients page
4 participants