fix: resolved issue #8583 - Increased width to remove unnecessary scrollbar #8630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move unnecessary scrollbar which appeared on the investigation details page
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
// updated comments
rithviknishad
requested changes
Sep 26, 2024
Comment on lines
+23
to
+29
| {/* INCREASED WIDTH TO REMOVE SCROLLBAR */} | ||
|
|
||
| {/* PREVIOUS WIDTH = 50REM | ||
|
|
||
| UPDATED WIDTH = 64REM */} | ||
|
|
||
| <div className="mx-auto my-8 lg:w-[64rem]"> |
There was a problem hiding this comment.
This is a reusable component meant to be used to show how to print would look like. Instead of modifying this component, let's have two pages:
-
The one that shows the Investigation Details with all the interactive components such as update details, select menu etc...
-
And a print button that takes you to the print preview page, which will not have any interactive components in the print preview. Select Menu doesn't and other interactive elements should not be part of the "print preview".
|
@syedfardeenjeelani any update on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
PrintPreviewpage to 64rem to remove the unnecessary scrollbar on the investigation details page.@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Here is a screenshot of the fix:
