Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera feed fullscreen bug #8650

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix camera feed fullscreen bug #8650

merged 2 commits into from
Sep 27, 2024

Conversation

shivankacker
Copy link
Member

Proposed Changes

  • Fixes an issue with the camera controls clipping out on fullscreen on chrome

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner September 27, 2024 11:29
@shivankacker shivankacker self-assigned this Sep 27, 2024
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 9d8ad89
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f6aac0c431090008e06135
😎 Deploy Preview https://deploy-preview-8650--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d8ad89
Status: ✅  Deploy successful!
Preview URL: https://6442250f.care-fe.pages.dev
Branch Preview URL: https://fix-camera-fullscreen.care-fe.pages.dev

View logs

Copy link

cypress bot commented Sep 27, 2024

CARE    Run #3475

Run Properties:  status check passed Passed #3475  •  git commit 9d8ad89ff9: Fix camera feed fullscreen bug
Project CARE
Branch Review fix-camera-fullscreen
Run status status check passed Passed #3475
Run duration 03m 36s
Commit git commit 9d8ad89ff9: Fix camera feed fullscreen bug
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

@shivankacker

image

the component is breaking in live feed now

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5ea49d1 into develop Sep 27, 2024
27 checks passed
@khavinshankar khavinshankar deleted the fix-camera-fullscreen branch September 27, 2024 13:56
Copy link

@shivankacker @shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants