Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README to include info on translations #8690

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

shivankacker
Copy link
Member

Proposed Changes

  • Adds a note explaining translations for languages other than english must be contributed through crowdin.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner October 2, 2024 05:20
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 36a4b17
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66fcd82f02b98900087bf951
😎 Deploy Preview https://deploy-preview-8690--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 36a4b17
Status: ✅  Deploy successful!
Preview URL: https://c1a580ae.care-fe.pages.dev
Branch Preview URL: https://translation-readme.care-fe.pages.dev

View logs

Copy link

cypress bot commented Oct 2, 2024

CARE    Run #3503

Run Properties:  status check failed Failed #3503  •  git commit 36a4b17b45: Updated README to include info on translations
Project CARE
Branch Review translation-readme
Run status status check failed Failed #3503
Run duration 03m 29s
Commit git commit 36a4b17b45: Updated README to include info on translations
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 122
View all changes introduced in this branch ↗︎

Tests for review

Failed  UsersCreation.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
User Creation > create new user and verify reflection Test Replay Screenshots
Failed  UsersProfile.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Manage User Profile > Adding video connect link for a user and verify its reflection in user profile and doctor connect Test Replay Screenshots

@bodhish
Copy link
Member

bodhish commented Oct 2, 2024

Why is the spec failing for an update readme PR 🤔

@bodhish bodhish merged commit 52d05eb into develop Oct 2, 2024
26 of 29 checks passed
@bodhish bodhish deleted the translation-readme branch October 2, 2024 19:13
Copy link

github-actions bot commented Oct 2, 2024

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants