Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Qualification field for nurse user type #8694

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Fix: Qualification field for nurse user type #8694

merged 9 commits into from
Oct 3, 2024

Conversation

AdityaJ2305
Copy link
Contributor

@AdityaJ2305 AdityaJ2305 commented Oct 3, 2024 •
edited by rithviknishad
Loading

Required Backends:

Proposed Changes

Screenshots

Screenshot 2024-10-03 at 12 28 58 PM Screenshot 2024-10-03 at 12 29 54 PM Screenshot 2024-10-03 at 12 52 48 PM

@ohcnetwork/care-fe-code-reviewers
@rithviknishad

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews

@AdityaJ2305 AdityaJ2305 requested a review from a team as a code owner October 3, 2024 07:24
@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 3429a29
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66fe86468dd51b0008561a5d
😎 Deploy Preview https://deploy-preview-8694--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2024 •
edited
Loading

Testing Note [ In Progress ]

  • user skill addition in user tab card
  • edit profile user skills

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2024

LGTM

@nihal467 nihal467 added the tested label Oct 3, 2024
khavinshankar
khavinshankar requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdityaJ2305 The changes look good, please add i18n

@AdityaJ2305
Copy link
Contributor Author

@khavinshankar Sure

@nihal467 nihal467 added the P1 breaking issue or vital feature label Oct 3, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 3, 2024

@AdityaJ2305 can you push the request changes ASAP, since the related backend is merged, the frontend functionality is failing in develop

@AdityaJ2305
Copy link
Contributor Author

AdityaJ2305 commented Oct 3, 2024 •
edited
Loading

Yes , Should i add i18n for unknown text only and for all languages supported by care ?

@rithviknishad
Copy link
Member

https://github.com/ohcnetwork/care_fe#translations

@AdityaJ2305
Copy link
Contributor Author

Done

khavinshankar
khavinshankar requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdityaJ2305 you missed i18n in few places

src/Components/Users/ManageUsers.tsx Outdated Show resolved Hide resolved
src/Components/Users/ManageUsers.tsx Show resolved Hide resolved
src/Components/Users/ManageUsers.tsx Show resolved Hide resolved
src/Components/Users/ManageUsers.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserAdd.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
@khavinshankar khavinshankar merged commit e44e245 into ohcnetwork:develop Oct 3, 2024
24 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

@AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qualification field for nurse user type
4 participants
@AdityaJ2305 @nihal467 @rithviknishad @khavinshankar