Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store the camera position correctly in camera preset create #8710

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Oct 4, 2024

Proposed Changes

  • we were not sending the positoion object in the meta in asset create

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner October 4, 2024 16:11
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 4bf8f74
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670013b2305a3000083f5e32
😎 Deploy Preview https://deploy-preview-8710--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bf8f74
Status: ✅  Deploy successful!
Preview URL: https://5a014cbb.care-fe.pages.dev
Branch Preview URL: https://sainak-fix-onvif-preset-crea.care-fe.pages.dev

View logs

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2024

LGTM

Copy link

cypress bot commented Oct 4, 2024

CARE    Run #3534

Run Properties:  status check passed Passed #3534  •  git commit 4bf8f74223: store the camera position correctly in camera preset create
Project CARE
Branch Review sainak/fix/onvif-preset-create
Run status status check passed Passed #3534
Run duration 03m 10s
Commit git commit 4bf8f74223: store the camera position correctly in camera preset create
Committer Aakash Singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124
View all changes introduced in this branch ↗︎

@rithviknishad rithviknishad merged commit 8e6a2f2 into develop Oct 4, 2024
29 checks passed
@rithviknishad rithviknishad deleted the sainak/fix/onvif-preset-create branch October 4, 2024 16:20
Copy link

github-actions bot commented Oct 4, 2024

@sainak @sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants