Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient Registration Form: Move restore draft button beside generate/link abha number #8741

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 8, 2024

Proposed Changes

  • Patient Registration Form: Move restore draft button beside generate/link abha number
image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner October 8, 2024 12:30
@rithviknishad rithviknishad self-assigned this Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit faa6377
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670774248bdd200008697939
😎 Deploy Preview https://deploy-preview-8741--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: faa6377
Status: ✅  Deploy successful!
Preview URL: https://082fc737.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-move-resto.care-fe.pages.dev

View logs

Copy link

cypress bot commented Oct 8, 2024

CARE    Run #3580

Run Properties:  status check passed Passed #3580  •  git commit faa63778b7: Patient Registration Form: Move restore draft button beside generate/link abha n...
Project CARE
Run status status check passed Passed #3580
Run duration 03m 25s
Commit git commit faa63778b7: Patient Registration Form: Move restore draft button beside generate/link abha n...
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 120

Copy link
Member

@gigincg gigincg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the onlyChild prop her? I couldn't find any usage of it

@bodhish
Copy link
Member

bodhish commented Oct 9, 2024

@rithviknishad I think we should keep only one button at the top. The abha button can be placed below just to avoid conflicts on mobile.

@gigincg gigincg merged commit ca2c92a into develop Oct 10, 2024
29 checks passed
@gigincg gigincg deleted the rithviknishad/fix/move-restore-draft-button branch October 10, 2024 08:47
Copy link

@rithviknishad @rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants