Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Infinite Scrolling and Previous Item Persistence in Notifications #8771

Conversation

shauryag2002
Copy link
Contributor

Proposed Changes

Video of changes:

infinite-scroll-notification.mp4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shauryag2002 shauryag2002 requested a review from a team as a code owner October 13, 2024 10:42
Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 6324be2
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670ea31253f6790008fe50ac
😎 Deploy Preview https://deploy-preview-8771--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@shauryag2002

image

  • currently we are having two loader in the notification, remove one among the two loader for the infinite loading

@shauryag2002
Copy link
Contributor Author

@nihal467 , Removed load more button

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit cafe126 into ohcnetwork:develop Oct 16, 2024
24 checks passed
Copy link

@shauryag2002 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Scrolling and Previous Item Persistence in Notifications
5 participants