-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Update: Rounding off the PCO2 values to nearest integer #8776
Log Update: Rounding off the PCO2 values to nearest integer #8776
Conversation
- Error messages for PO2, PCO2 and Base Excess.
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@rithviknishad @Jacobjeevan once the PR is read for review, post a comment or change the label to need testing |
- removed the parameter added to keep track if field should be int only
@Jacobjeevan you need to add |
regarding this issue, Actually the PCo2 and Po2 fields needs at least two decimal places. @nihal467 should i file an another issue or can we do it here itself:? the same fields needs another option to switch between "mmHg" and "Kpa" units. currently there is only "mmHg" unit. both units needs atleast two decimal places. also "pH" needs three decimal places. refer the below abg results |
@nihal467 talked with aparna and filing this as a new issue |
|
Hmm, Sam already filed an issue for this and looks like someone is working on it 🤔 #8858 What do you think? Let them handle it, or should I just make the modification in this PR itself? @nihal467 |
👋 Hi, @Jacobjeevan, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@Jacobjeevan lets get this merged |
It's good to go, since @abhip161 is working on #8858 and #8859 , I'll let them handle the rest 👍 |
LGTM |
@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
Backend doesn't accept decimal values for certain fields, so rounding the values to nearest integer instead.
@ohcnetwork/care-fe-code-reviewers
Merge Checklist