Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Update: Rounding off the PCO2 values to nearest integer #8776

Merged

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 14, 2024

Proposed Changes

Backend doesn't accept decimal values for certain fields, so rounding the values to nearest integer instead.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 14, 2024 07:32
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit dd65b08
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6718fd4d3bce880008c6ae26
😎 Deploy Preview https://deploy-preview-8776--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@rithviknishad @Jacobjeevan once the PR is read for review, post a comment or change the label to need testing

- removed the parameter added to keep track if field should be int only
@bodhish
Copy link
Member

bodhish commented Oct 21, 2024

@Jacobjeevan you need to add need testing label for it to be tested.

@samholics
Copy link

regarding this issue, Actually the PCo2 and Po2 fields needs at least two decimal places. @nihal467 should i file an another issue or can we do it here itself:? the same fields needs another option to switch between "mmHg" and "Kpa" units. currently there is only "mmHg" unit. both units needs atleast two decimal places. also "pH" needs three decimal places. refer the below abg results
eg:
image
image

@samholics
Copy link

regarding this issue, Actually the PCo2 and Po2 fields needs at least two decimal places. @nihal467 should i file an another issue or can we do it here itself:? the same fields needs another option to switch between "mmHg" and "Kpa" units. currently there is only "mmHg" unit. both units needs atleast two decimal places. also "pH" needs three decimal places. refer the below abg results eg: image image

@nihal467 talked with aparna and filing this as a new issue

@nihal467
Copy link
Member

nihal467 commented Oct 22, 2024

@Jacobjeevan

  • we should allow PCO2 to have decimal values per the issue. Following the standard, allow up to two decimal points for the PCO2. Please make the changes in this PR and update the backend accordingly to support it.

@Jacobjeevan
Copy link
Contributor Author

Jacobjeevan commented Oct 22, 2024

@Jacobjeevan

* [ ]  we should allow PCO2 to have decimal values per the issue. Following the standard, allow up to two decimal points for the PCO2. Please make the changes in this PR and update the backend accordingly to support it.

Hmm, Sam already filed an issue for this and looks like someone is working on it 🤔 #8858 What do you think? Let them handle it, or should I just make the modification in this PR itself? @nihal467

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Jacobjeevan Jacobjeevan added changes required and removed changes required merge conflict pull requests with merge conflict labels Oct 23, 2024
@bodhish
Copy link
Member

bodhish commented Oct 23, 2024

@Jacobjeevan lets get this merged

@Jacobjeevan
Copy link
Contributor Author

@Jacobjeevan lets get this merged

It's good to go, since @abhip161 is working on #8858 and #8859 , I'll let them handle the rest 👍

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 changed the title Log Update: disallow decimals for certain fields Log Update: Rounding off the PCO2 values to nearest integer Oct 27, 2024
@nihal467 nihal467 changed the title Log Update: Rounding off the PCO2 values to nearest integer Log Update: disallow decimals for certain fields Oct 27, 2024
@nihal467 nihal467 changed the title Log Update: disallow decimals for certain fields Log Update: Rounding off the PCO2 values to nearest integer Oct 27, 2024
@bodhish bodhish merged commit 9a0d27b into ohcnetwork:develop Oct 27, 2024
32 checks passed
Copy link

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABG Log update -PCO2 decimal number entry not allowed.
5 participants