Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes multiple tiny issues #8784

Merged
merged 22 commits into from
Oct 16, 2024
Merged

Fixes multiple tiny issues #8784

merged 22 commits into from
Oct 16, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 14, 2024 •
edited
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner October 14, 2024 12:59
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 30000ad
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670f91c14f8b460008512efc
😎 Deploy Preview https://deploy-preview-8784--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30000ad
Status: ✅  Deploy successful!
Preview URL: https://2f4ab1fd.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-tiny-issue.care-fe.pages.dev

View logs

@cypress Cypress
Copy link

cypress bot commented Oct 14, 2024 •
edited
Loading

CARE    Run #3679

Run Properties:  status check passed Passed #3679  •  git commit 30000ad018: Fixes multiple tiny issues
Project CARE
Run status status check passed Passed #3679
Run duration 03m 19s
Commit git commit 30000ad018: Fixes multiple tiny issues
Committer Rithvik Nishad
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@nihal467
Copy link
Member

nihal467 commented Oct 14, 2024 •
edited by rithviknishad
Loading

image

  • the text badge overlaps with patient card details in mobile view when there is no bed assigned to the patient

image
image

  • in the mobile view, when there is no facility cover image, its still showing the old icon

image

  • the collapse icon is not working in the mobile view

@nihal467
Copy link
Member

@rithviknishad can you fix the minor bugs mentioned above, rest of them looks good

@nihal467
Copy link
Member

nihal467 commented Oct 15, 2024 •
edited by rithviknishad
Loading

@rithviknishad
image

  • in the mobile view, keep the card size content in the patient list page

bodhish
bodhish approved these changes Oct 15, 2024
View reviewed changes
src/Routers/AppRouter.tsx Show resolved Hide resolved
src/Locale/en.json Show resolved Hide resolved
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b02062a into develop Oct 16, 2024
26 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/tiny-issues branch October 16, 2024 10:23
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish bodhish approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discharged page jumps to page 1 Bugs Detected After Merging PR #8737 , PR #8706, PR #8680
4 participants
@rithviknishad @nihal467 @bodhish @khavinshankar