Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ventilator mode/Oxygen modality data as exclusive of each other #8852

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Jacobjeevan
Copy link
Contributor

Modified onChange in Ventilator/Oxygen mode to ensure values for ventilator mode/oxygen modality remain exclusive to each other.

To illustrate, right now if the user selects NIV, then PCV as ventilator mode, then switches to Oxygen support and simple face mask as the modality. You get the following in the daily log:

image

Same applies for the value fields under mode/modality.

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

- for Ventilator mode/oxygen modality (i.e. to ensure values aren't preserved on mode/modality change)
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5623351
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6718fce51dea400008541b21
😎 Deploy Preview https://deploy-preview-8852--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
@Jacobjeevan Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 23, 2024
@bodhish bodhish merged commit 5502433 into ohcnetwork:develop Oct 23, 2024
22 checks passed
Copy link

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

noufalrahim pushed a commit to noufalrahim/care_fe that referenced this pull request Oct 24, 2024
@Jacobjeevan Jacobjeevan deleted the issues/8845-ventilatorData branch November 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ventilator mode/Oxygen modality data not treated as exclusive when passing to BE
4 participants