Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UI for list view for Resources and Shifting #8934

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Oct 26, 2024

Proposed Changes

Screenshot 2024-10-27 at 1 09 17 AM

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner October 26, 2024 19:36
Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit cdce147
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671d49cb186e610008d681dd
😎 Deploy Preview https://deploy-preview-8934--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Oct 26, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: cdce147
Status: ✅  Deploy successful!
Preview URL: https://798a43ad.care-fe.pages.dev
Branch Preview URL: https://resource-shifting-list.care-fe.pages.dev

View logs

Copy link

cypress bot commented Oct 26, 2024

CARE    Run #3751

Run Properties:  status check passed Passed #3751  •  git commit cdce147d88: Updated UI for list view for Resources and Shifting
Project CARE
Branch Review resource-shifting-list
Run status status check passed Passed #3751
Run duration 03m 08s
Commit git commit cdce147d88: Updated UI for list view for Resources and Shifting
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@bodhish
Copy link
Member

bodhish commented Oct 27, 2024

@shivankacker Can you check these PR's and get them reviewed and merged? I am seeing them have a lot of overlap with this PR.

@shivankacker
Copy link
Member Author

@bodhish Didn't notice the Table UI PR before. The other PR will not interfere much. This PR adds a lot of changes for the structure of files and models. We can merge either of the PRs first but I think the Table UI one has some changes to do and has merge conflicts to resolve. We can merge this so the new file structure and models get reflected.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; just minor things

src/components/Shifting/ShiftingBoard.tsx Show resolved Hide resolved
src/components/Resource/ResourceList.tsx Show resolved Hide resolved
src/components/Shifting/ShiftingList.tsx Show resolved Hide resolved
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 09b12e1 into develop Oct 30, 2024
28 checks passed
@khavinshankar khavinshankar deleted the resource-shifting-list branch October 30, 2024 07:33
Copy link

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI for list view in shifting and resource boards
5 participants