Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCX Plug FE #8943

Merged
merged 9 commits into from
Oct 30, 2024
Merged

HCX Plug FE #8943

merged 9 commits into from
Oct 30, 2024

Conversation

khavinshankar
Copy link
Member

Note

Policies are kept in the main repo to support policies being added even when plug is not enabled.

@khavinshankar khavinshankar requested a review from a team as a code owner October 28, 2024 07:02
@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit ed4753f
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6721ef2355ad8d0008ada78a
😎 Deploy Preview https://deploy-preview-8943--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Oct 28, 2024 •
edited
Loading

CARE    Run #3774

Run Properties:  status check passed Passed #3774  •  git commit ed4753f3fa: HCX Plug
Project CARE
Branch Review hcx-plug-fe
Run status status check passed Passed #3774
Run duration 03m 17s
Commit git commit ed4753f3fa: HCX Plug
Committer Khavin Shankar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 28, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed4753f
Status: ✅  Deploy successful!
Preview URL: https://8ecb216f.care-fe.pages.dev
Branch Preview URL: https://hcx-plug-fe.care-fe.pages.dev

View logs

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 28, 2024
@khavinshankar khavinshankar added needs testing reviewed reviewed by a core member labels Oct 28, 2024
@nihal467
Copy link
Member

image

the Entire UI of pre-auth is broken, can you check it once

@khavinshankar
Copy link
Member Author

@nihal467 fixed the styling issues, it was caused because tailwind classes in plugs were not recognized (i.e., any new tailwind class used in the plug will not work)

image

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 30, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Oct 30, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 30, 2024
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 30, 2024
@khavinshankar khavinshankar removed the Deploy-Failed Deplyment is not showing preview label Oct 30, 2024
@nihal467
Copy link
Member

LGtM

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit eb2c702 into develop Oct 30, 2024
25 checks passed
@khavinshankar khavinshankar changed the title HCX Plug HCX Plug FE Oct 30, 2024
@khavinshankar khavinshankar deleted the hcx-plug-fe branch October 30, 2024 08:53
@github-actions GitHub Actions
Copy link

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@khavinshankar khavinshankar mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees

@khavinshankar khavinshankar

Labels
reviewed reviewed by a core member tested
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khavinshankar @nihal467 @rithviknishad