Fix: Inconsistency in Title during creation of Resouce Request #9440 #9442

srijantrpth · 2024-12-15T16:26:37Z

Proposed Changes

Fixes Inconsistency in title during creation of Resouce Request #9440
Changed the title of Description of Request to Reason of Request while creating new resource request and updating a resource request

Before:

After:

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Updated terminology in the user interface, changing "Description of Request" to "Reason of Request" across multiple components and localization files.
Bug Fixes
- Ensured that the updated labels maintain clarity and consistency in user-facing messages.
Documentation
- Revised localization strings in English, Hindi, Kannada, Malayalam, Tamil, and other languages to enhance user understanding of input fields.

coderabbitai · 2024-12-15T16:26:45Z

Walkthrough

This pull request addresses an inconsistency in terminology across the application's resource request interface. The changes involve updating the label from "Description of Request" to "Reason of Request" in multiple files, including the English localization file (en.json) and React components (ResourceDetails.tsx, ResourceDetailsUpdate.tsx, ResourceCreate.tsx). The modification aims to provide a consistent and clear user interface label for the request reason field.

Changes

File	Change Summary
`public/locale/en.json`	Updated `"request_description"` key from "Description of Request" to "Reason of Request"
`public/locale/hi.json`	Renamed `"request_description"` to `"request_reason"`
`public/locale/kn.json`	Renamed `"request_description"` to `"request_reason"`
`public/locale/ml.json`	Renamed `"request_description"` to `"request_reason"`
`public/locale/ta.json`	Renamed `"request_description"` to `"request_reason"`
`src/components/Resource/ResourceDetails.tsx`	Changed label from "Description of Request:" to "Reason of Request"
`src/components/Resource/ResourceDetailsUpdate.tsx`	Updated TextAreaFormField label from "Description of request" to "Reason of Request"
`src/components/Resource/ResourceCreate.tsx`	Updated TextAreaFormField label from "request_description" to "request_reason"

Assessment against linked issues

Objective	Addressed	Explanation
Resolve inconsistent title for resource request field [#9440]	✅
Align title across creation, update, and display stages	✅

Possibly related PRs

Fix Conditional Rendering of TextAreaFormField for Sample Test Type #8960: This PR modifies the TextAreaFormField in the SampleTest component, which is related to the terminology change from "Description of Request" to "Reason of Request" in the main PR.
Design of List View layout in Resource Page #9096: This PR updates the public/locale/en.json file by adding new key-value pairs, which may relate to the overall localization efforts reflected in the main PR's changes to the same file.
Scribe Enhancements support PR #9265: This PR also adds a new key-value pair to public/locale/en.json, contributing to the localization updates similar to those in the main PR.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
shivankacker

Poem

🐰 A rabbit's tale of words so bright,
Changing "Description" with delight,
"Reason" now takes center stage,
Clarity leaps from page to page,
A linguistic hop that sets things right! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ba2733 and 8b0eec9.

📒 Files selected for processing (1)

public/locale/hi.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

public/locale/hi.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-15T16:26:57Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`9deb682`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/675fb8c9dc482c00087c93d1
😎 Deploy Preview	https://deploy-preview-9442--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f82dfa8 and 31a5c6b.

📒 Files selected for processing (3)

public/locale/en.json (1 hunks)
src/components/Resource/ResourceDetails.tsx (1 hunks)
src/components/Resource/ResourceDetailsUpdate.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (2)

public/locale/en.json
src/components/Resource/ResourceDetailsUpdate.tsx

src/components/Resource/ResourceDetails.tsx

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31a5c6b and 7e76e14.

📒 Files selected for processing (6)

public/locale/en.json (1 hunks)
public/locale/hi.json (1 hunks)
public/locale/kn.json (1 hunks)
public/locale/ml.json (1 hunks)
public/locale/ta.json (1 hunks)
src/components/Resource/ResourceCreate.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (4)

public/locale/ml.json
src/components/Resource/ResourceCreate.tsx
public/locale/ta.json
public/locale/kn.json

🚧 Files skipped from review as they are similar to previous changes (1)

public/locale/en.json

public/locale/hi.json

srijantrpth · 2024-12-15T17:04:27Z

@coderabbitai review

coderabbitai · 2024-12-15T17:04:38Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

srijantrpth · 2024-12-15T18:07:21Z

Hi @rithviknishad @shivankacker Kindly review the PR and let me know if any changes are required. Thanks!

rithviknishad

https://github.com/ohcnetwork/care_fe?tab=readme-ov-file#translations

avoid adding other languages

srijantrpth · 2024-12-16T05:00:20Z

Hi @rithviknishad , I have reverted the translation for other languages. The JSON keys are same as the English language to ensure the consistency throughout the codebase

github-actions · 2024-12-16T05:45:22Z

@srijantrpth Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Fix title during creation of Resource Request

31a5c6b

srijantrpth requested a review from a team as a code owner December 15, 2024 16:26

coderabbitai bot reviewed Dec 15, 2024

View reviewed changes

src/components/Resource/ResourceDetails.tsx Show resolved Hide resolved

Fix Translation Key in Resource Request

7e76e14

coderabbitai bot reviewed Dec 15, 2024

View reviewed changes

public/locale/hi.json Show resolved Hide resolved

Fix Hindi Translations of Resource Request

6ba2733

rithviknishad requested changes Dec 16, 2024

View reviewed changes

Reverted the Translation for Other Languages

8b0eec9

srijantrpth requested a review from rithviknishad December 16, 2024 04:58

rithviknishad approved these changes Dec 16, 2024

View reviewed changes

Merge branch 'develop' into issues/9440#/title-issue

9deb682

rithviknishad merged commit 5d9885b into ohcnetwork:develop Dec 16, 2024
19 checks passed

rithviknishad added the tested label Dec 16, 2024

This was referenced Dec 16, 2024

Update Resource Forms to Enhance Validation #9062

Closed

Add base for fhir forms #9262

Merged

Use shadcn Tooltip Components across FacilityCard #9317

Merged

srijantrpth deleted the issues/9440#/title-issue branch December 17, 2024 17:03

This was referenced Dec 17, 2024

FIXED: The APPROVAL LETTER is not wrapped with the <PrintPreview> component #9479

Merged

Fixed Multi-selection functionality. #9345

Closed

This was referenced Dec 31, 2024

Fix : View Retention in Users Tab After Navigation #9485

Closed

Appointment as structured question + other enhancements #9661

Merged

Enhanced Resource Page #9743

Closed

Enhanced Resource Page #9768

Closed

This was referenced Jan 7, 2025

Fix Online Status Indicator in Organization Tab #9728

Merged

Username validation added in Create user form #9835

Merged

Fix: Replace InputWithError and InputErrors components with ShadCN’s components directly. #9847

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Inconsistency in Title during creation of Resouce Request #9440 #9442

Fix: Inconsistency in Title during creation of Resouce Request #9440 #9442

srijantrpth commented Dec 15, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 15, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 15, 2024 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

srijantrpth commented Dec 15, 2024

coderabbitai bot commented Dec 15, 2024

srijantrpth commented Dec 15, 2024

rithviknishad left a comment

srijantrpth commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

Fix: Inconsistency in Title during creation of Resouce Request #9440 #9442

Fix: Inconsistency in Title during creation of Resouce Request #9440 #9442

Conversation

srijantrpth commented Dec 15, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Dec 15, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 15, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

srijantrpth commented Dec 15, 2024

coderabbitai bot commented Dec 15, 2024

srijantrpth commented Dec 15, 2024

rithviknishad left a comment

Choose a reason for hiding this comment

srijantrpth commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

srijantrpth commented Dec 15, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 15, 2024 •

edited

Loading