changed OP Number to Registration Number

[modamaan]

Proposed Changes

• Fixes Registration Number for domiciliary Care #9513
• change 1
  

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Updated label for the patient_no field from "OP Number" to "Registration Number" when the suggestion is not "A".
  • Enhanced validation for the patient_no field to ensure it is required when the suggestion is "A".
  • Adjusted handling of the suggestion field to set specific values in the form state, including setting consultation_notes to "Patient declared dead" for suggestion "DD".

• Bug Fixes

  • Improved error handling logic to display appropriate error messages based on form state.

[coderabbitai]

Walkthrough

The pull request modifies the ConsultationForm component in src/components/Facility/ConsultationForm.tsx. The primary changes include renaming the "OP Number" label to "Registration Number" when the suggestion is not "A", and enhancing form validation logic. The validation now ensures the patient_no field is required when the suggestion is "A" and is not just whitespace. Additionally, when the suggestion is "DD" (patient deceased), the consultation_notes are automatically set to "Patient declared dead".

Changes

File	Change Summary
src/components/Facility/ConsultationForm.tsx	- Updated label from "OP Number" to "Registration Number" - Enhanced validation for patient_no field - Added automatic consultation_notes for deceased patients - Modified type of patient_no to allow null

Assessment against linked issues

Objective	Addressed	Explanation
Change "OP Number" to "Registration Number" [#9513]	✅

Possibly related PRs

• fix: Resolve creation of patient name despite having numeric values #9152: Modifies validation logic in PatientRegister.tsx
• Add function to authorize user to register patient #9000: Involves user authorization in FacilityHome component
• Added SpO2 field in community log update for nurses #8907: Introduces new form field with validation and state management

Suggested labels

needs review, tested

Suggested reviewers

• rithviknishad
• Jacobjeevan

Poem

🐰 A rabbit's tale of form delight,
Registration numbers now shine bright!
From OP to reg, a semantic dance,
Validation leaps with newfound stance.
Code hops forward, clear and true! 🏥

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	af608a8
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67654435f1fd91000870f139
😎 Deploy Preview	https://deploy-preview-9521--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 949624f and 6ca508f.

📒 Files selected for processing (1)

• src/components/Facility/ConsultationForm.tsx (1 hunks)

[Jacobjeevan]

Closing as changes would need to be made in the new branch (a lot has changed); also don't work on the issues until they are assigned 👍 These issues in particular are blocked.