Drop Carbon dependency, replace with DateTimeImmutable
#47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Carbon's long-awaited 3.0 release being out the door 🎉, I discovered that the Oh Dear SDK was blocking the upgrade of one of our internal libraries because of its dependency on
nesbot/carbon:^2.65.0
.As it turns out, however, Carbon is only being used by one method:
ohdear-php-sdk/src/OhDear.php
Lines 81 to 84 in d306069
With this in mind, it seemed more efficient to just use the native
DateTimeImmutable
instead of depending on an external library, especially with a new major release of it being out in the wild now.This PR drops the dependency on Carbon and replaces it with a simple call to
DateTimeImmutable::format()
, while keeping green checks in the tests.