Fixed a bug where ampersand character (&) was escaped in Child operators #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes what seems to be a bug in the string serialisation for expressions.
The ampersand
&
character got escaped into\h
which, besides not being the right string, also isn't a valid according tojp.ParseString
, eg (https://go.dev/play/p/BDjHacoE4Hu):Shows the error:
I've added some basic tests covering this, but I'm unfamiliar with other parts of the code. I think the only place this is relevant is in
ojg/string.go
Lines 61 to 69 in aede9ec
&
is special. I think the mapping got copied over and this bug sneaked in.