Support Indexed and Keyed interfaces when removing nodes #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I agree the Indexed interface should probably have had a Other than that the PR looks good although I did not verify coverage yet. |
|
@ohler55 Updated per your suggestion. |
ohler55
approved these changes
Aug 30, 2024
|
Been on vacation. Sorry for the delay. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
IndexedandKeyedinterfaces when removing nodes from an expression.Note: I needed to add a method for removing items from
Indexed. If you'd rather avoid a breaking change, we could moveRemoveValueAtIndexto a separate interface. I originally went down that route, but got stuck trying to come up with a name.MutableIndexedwas the only thing I could come up with and... it doesn't really sound great to me 😬. Let me know what you prefer (or feel free to take over this PR).Also, a belated thank you for fixing #156 ❤️! I tried out the latest release and it works great.