-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Ruby 3.2 "undefining the allocator of T_DATA class" warnings #299
Resolve Ruby 3.2 "undefining the allocator of T_DATA class" warnings #299
Conversation
warning: undefining the allocator of T_DATA class Ox::Cache warning: undefining the allocator of T_DATA class Ox::Sax::Value See: https://bugs.ruby-lang.org/issues/18007 Order of dumped XML elements changed in a test, but I believe the change is not significant.
Looks like some tests are failing. Would you mind taking a look? |
I guess this patch may make test suite pass on ruby3.2preview3 and onwards, but this makes test failure on ruby3.1 and downwards. |
Maybe a change in the extconf.rb along with a |
exported, but not requiring them be in a particular order.
I updated the test to require both elements be exported, but not to depend on the order of the elements. |
I'm happy to put an #if guard in, if you prefer that as a solution. Just let me know. |
Ox does need to work with older Rubies as well so unless you can get it to work in some other way the |
Yeah, sorry. Not enough coffee this morning. How does this look? I tested with 3.2-rc1, 3.1.3 and 2.7.6. |
Kicked off the CI to see how it fares. |
LGTM |
Thanks. It's nice to have others helping out. |
warning: undefining the allocator of T_DATA class Ox::Cache
warning: undefining the allocator of T_DATA class Ox::Sax::Value
See: https://bugs.ruby-lang.org/issues/18007
Order of dumped XML elements changed in a test, but I believe the change is not significant.