Use native vcv 2 widgets #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files where just edited for colors, and the 1s knob was edited from the native rack 1ps.
Since rack 2, dimension are more accurate and design more beautiful, so let's use that instead.
The license section needs to be updated, as we derive some work from vcv rack, which has a GPLv3 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the rogan knob and trim pot designs from VCV Rack in the simulator, as their physical dimensions are now more accurate, and design is more realistic and beautiful.
It also adds support for the Rogan 1S and 2S black for the
Encoder.