Skip to content

Commit

Permalink
ci: return true if command fails (appsmithorg#38662)
Browse files Browse the repository at this point in the history
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12783144157>
> Commit: 0a2d970
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12783144157&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Settings
> Spec: 
> It seems like **no tests ran** 😔. We are not able to recognize it,
please check <a
href="https://github.com/appsmithorg/appsmith/actions/runs/12783144157"
target="_blank">workflow here</a>.
> <hr>Wed, 15 Jan 2025 07:01:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated description for PR number input parameter in GitHub Actions
workflow configuration

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
sagar-qa007 authored Jan 15, 2025
1 parent df5ef9b commit 0106489
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
docker image ls --all --no-trunc --format '{{.Repository}},{{.ID}}' \
| grep -v cicontainer \
| cut -d, -f2 \
| xargs -r docker rmi
| xargs -r docker rmi || true
docker save cicontainer -o cicontainer.tar
gzip cicontainer.tar
Expand Down

0 comments on commit 0106489

Please sign in to comment.