Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove forge conditional recipe type #316

Merged
merged 1 commit into from
Aug 23, 2022
Merged

remove forge conditional recipe type #316

merged 1 commit into from
Aug 23, 2022

Conversation

rlnt
Copy link

@rlnt rlnt commented Aug 23, 2022

The forge conditional recipe type is a pain to work with when writing mods that integrate with other mods or JSON recipes.

Since you don't define multiple recipes inside a JSON file, there is no need to use this recipe type. Instead, you can use the conditions property inside a recipe JSON.

I tested the new recipes with and without Immersive Engineering. No errors and no warnings about the recipes and they still load fine when IE is loaded.
Please consider merging this and use the same format for future recipes as this make cross mod compatibility a lot easier.

@oitsjustjose
Copy link
Owner

Ah, thanks! This facet of Forge's conditional system isn't well documented, the only thing I ever can find on the readthedocs is the method I was using before.

Thank you for these changes!!

@oitsjustjose oitsjustjose merged commit edfd3fd into oitsjustjose:1.18 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants