Adds matchGlob functionality & resolves 0.0.0.0 error inside Docker Compose #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesvillarrubia
changed the title
|
@oittaa any updates on this? |
|
Sorry, I've been a bit busy and haven't had really time to check this project, but I just added Python 3.12 support. Could you resolve the remaining conflicts and then I'll merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying GCS client library now supports the matchGlob capability.
Syntax is outlined here
Because syntax is non-standard glob matching, customized filtering on gcs file paths had to be created in the get_file_list function.
PR also includes the requisite upgrade for the underlying google client.
Testing is provided for the internal unit tests as well as the external integration tests via the client. All tests have been manually matched against the GCS responses, so they should represent real cloud performance despite their odd glob patterns.
Additionally, resolves #210 and possibly #82