[Blocked] Update Cypress to 4.0.1 #829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
force-pushed
the
task/826-update-cypress-4.0.1
branch
from
067963f
to
aea30a9
Compare
sandrina-p
force-pushed
the
task/826-update-cypress-4.0.1
branch
from
aea30a9
to
820cdb2
Compare
sandrina-p
changed the title
|
I seriously think we should wait for a more stable release of Cypress 4.x. There are quite a lot of people opening/supporting new issues related to performance and bugs on this new version. I'll be closing this PR until a more stable version is released. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #826
Notes
Now the build takes 1min longer because of one spec. See run 284 - master vs run 285 - this PR. The spec "Large Group" takes 2:29m to run instead of 1:36m. I checked these issues but without conclusive answers: Tests that iterate over many DOM elements with
.each()run slower in Electron duringcypress runin 3.8.0 cypress-io/cypress#5987 and Cypress performance degrades to the point of failure in Chrome 79 on Ubuntu cypress-io/cypress#6023. I opened a new issue Cypress 4.0.1 - Electron is 1.5x slower in a test spec cypress-io/cypress#6388Firefox is still on beta. There is already an open issue where Firefox "default" doesn't work on MacOS Still cannot open Firefox in 4.0.1 on MacOS cypress-io/cypress#6387 and I opened another where file-upload doesn't work: [Bug] Support Firefox (Cypress 4.0.1) abramenal/cypress-file-upload#154.
The remaining tests work fine on Firefox Developer Edition but keep in mind (@taoeffect) that Firefox containers extension will still not work because Cypress runs all the tests on the same container, as expected.