-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#826 Update Cypress #1042
#826 Update Cypress #1042
Conversation
51f062e
to
4023713
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR @snowteamer!
One request: could you please update your version of node and npm? The reason I ask is because using the latest version will produce a different package-lock.json
file. We'd like to use the latest version of it so as to avoid conflicts in PRs going forward.
E.g., when I test locally, I get a large diff after running npm install
that has a different lockfileVersion
:
-> % git diff
diff --git a/package-lock.json b/package-lock.json
index 2bdb51d7..48d74d2c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,8 +1,20071 @@
{
"name": "group-income-simple",
"version": "0.0.1",
- "lockfileVersion": 1,
+ "lockfileVersion": 2,
When I run npm version
, here are the values I get:
-> % npm version
{
'group-income-simple': '0.0.1',
npm: '7.0.15',
node: '15.4.0',
[ ... snip irrelevant values ... ]
You can update node to 15 using whatever package manager you're using, and if it doesn't update npm to at least 7.0.15 after doing that, then you can do it yourself by running npm i -g npm@latest
.
Finally, feel free to bump the minimum node version requirements in the README.md
from 12
to 15
.
That's indeed a good idea, now that our Travis config no longer mandates using Node v14. However, since this might be useful for other contributors, I will add that So I had to run |
Hmm this still causes a merge conflict and a rather large diff - should I temporarily use the exact Node and NPM versions listed in your console output? |
@snowteamer Let's try to troubleshoot this on Slack |
b4d2e3b
to
085dd57
Compare
Why: Hapi.js doesn't fully support Node v15 yet. See: https://stackoverflow.com/questions/65485160/hapi-js-cannot-read-property-statuscode-of-null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @snowteamer! Thank you for sending this in! 😄
Summary of changes
group-contributions.spec.js
to usenot.exist
instead ofnot.be.visible
(see nonexistent element assertions in the Cypress migration guide).Additional info
The overall Cypress run for this build took 3min 40s, which is 23s better than the run from #1041, and 14s better than the run from #1040.
Therefore, the performance issues mentionned in #829 seem to have been resolved, or to no longer be relevant.
As for the other issues, I'm not sure. There are a lot of open issues on the Cypress repo, but I didn't go as far as investigating enough of them to guess if the situation was better in version 3.5.
Maybe @sandrina-p could tell whether we can safely upgrade?
Closes #1042