Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Share" logs downloads immediately instead of sharing on mobile #2019

Closed
taoeffect opened this issue May 25, 2024 · 0 comments · Fixed by #2026
Closed

Clicking "Share" logs downloads immediately instead of sharing on mobile #2019

taoeffect opened this issue May 25, 2024 · 0 comments · Fixed by #2026

Comments

@taoeffect
Copy link
Member

Problem

Clicking this "Share" button immediately downloads the logs:

tmp-1716601953819

Solution

This behavior is fine on Desktop, but on mobile it should bring up the sharing panel.

@SebinSong SebinSong self-assigned this May 25, 2024
taoeffect pushed a commit that referenced this issue May 31, 2024
* update the namings here and there / add check for web-share availability

* add share functionality to the app-logs page

* work on CRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants