Failure to re-subscribe to chatroom channel after update

[taoeffect]

Problem

After deploying v0.5.6 to the testing site, the tab I had open in Brave reloaded and refreshed, and showed that for some reason a whole bunch of pubsub channels couldn't be joined:

bug.compressed.mov

The channel I was in at the moment (#new-private) was one of those channels.

On my phone I logged in and posted messages to that channel:

You can see that the bug #2061 got triggered again too.

But these messages did not appear on desktop! Meaning it really had stopped receiving updates and was no longer subscribed!

So I refreshed the page then to see what would happen.

After refreshing the page, I saw that these pubsub errors were still going on:

So in the screenshot above, you can see that the #general chatroom has been not been subscribed to, and that posting a message to it leaves it as pending, per #2061.

In the screenshot below, you can see that this really is the #general chatroom, as it has the right users in it:

Posting another message reproduces the behavior of #2061 with the previous message shown as no longer pending:

Also, when debugging and running sync with force:true on the #general chatroom to fetch new messages, when they got fetched the chatroom didn't scroll to the bottom as it's supposed to.

sbp('chelonia/contract/sync', chatroomID, { force: true })

Solution

Fix this failure to subscribe problem, and #2061 as well. They might be the same issue, or related issues.

One issue is that on the server we aren't adding all known contractIDs to the pubsub channels.

The only place they're added is here:

  'backend/server/handleEntry': async function (deserializedHEAD: Object, entry: string) {
    const contractID = deserializedHEAD.contractID
    sbp('okTurtles.data/get', PUBSUB_INSTANCE).channels.add(contractID)

We need to add all contractIDs on boot to the pubsub channels.