Contract ids instead of usernames #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoeffect
requested changes
Feb 5, 2024
frontend/controller/actions/group.js
Outdated
| } else { | ||
| const randDelay = randomIntFromRange(0, 1500) | ||
| console.warn(`autoBanSenderOfMessage: ${e.message} attempting to ban ${username}, retrying in ${randDelay} ms...`, e) | ||
| console.warn(`autoBanSenderOfMessage: ${e.message} attempting to ban ${member}, retrying in ${randDelay} ms...`, e) |
There was a problem hiding this comment.
We still want to print out their username here as well.
I haven't finished reviewing the PR yet so I don't know, but if there isn't a getter to go from identityContractID => username then this is a great time/place to use it and add one
There was a problem hiding this comment.
There is (as you also found out in another later comment), it was userUsername, which now is usernameFromID.
corrideat
force-pushed
the
contract-ids-instead-of-usernames
branch
from
d409873
to
beed4c6
Compare
Passing run #1856 ↗︎
Details:
Review all test suite changes for PR #1829 ↗︎ |
|||||||||||||||
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
taoeffect
reviewed
Feb 7, 2024
corrideat
force-pushed
the
contract-ids-instead-of-usernames
branch
from
86697c8
to
46bf6bc
Compare
This reverts commit 6769085.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.