Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2041 - Fix the In-app link panel not working #2042

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

SebinSong
Copy link
Collaborator

@SebinSong SebinSong commented Jun 4, 2024

closes #2041

Due to the recent update on how the markdown texts are rendered in this PR, the logic governing this needed to be updated accordingly too.

Proof of the fix:

@SebinSong SebinSong self-assigned this Jun 4, 2024
Copy link

cypress bot commented Jun 4, 2024

Passing run #2336 ↗︎

0 111 8 0 Flakiness 0

Details:

Merge 3e04d6e into a35504b...
Project: group-income Commit: 2680ef1c78 ℹ️
Status: Passed Duration: 10:01 💡
Started: Jun 4, 2024 9:35 PM Ended: Jun 4, 2024 9:45 PM

Review all test suite changes for PR #2042 ↗︎

@SebinSong SebinSong requested a review from taoeffect June 4, 2024 23:15
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for the quick fix!

@taoeffect taoeffect merged commit 8256b1b into master Jun 5, 2024
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2041-chat-link-not-working branch June 5, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing and holding on a link on mobile brings up the wrong panel
2 participants