Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2072 - capture tunnel logs #2073

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

taoeffect
Copy link
Member

Captures phone logs to server console run accessing via grunt dev --tunnel.

Adds new 'appLogs/logServer' selector that can be called manually if necessary before the log capture begins (when login is called). Generally speaking you won't need to call this manually and the logs will appear automatically on the backend, color coded.

Copy link

cypress bot commented Jun 14, 2024

Passing run #2405 ↗︎

0 106 8 0 Flakiness 0

Details:

Merge e36a881 into 80c3ffd...
Project: group-income Commit: e1271f97be ℹ️
Status: Passed Duration: 09:30 💡
Started: Jun 17, 2024 6:06 PM Ended: Jun 17, 2024 6:16 PM

Review all test suite changes for PR #2073 ↗︎

Copy link
Member

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @taoeffect! It works well.

frontend/model/captureLogs.js Outdated Show resolved Hide resolved
frontend/model/captureLogs.js Show resolved Hide resolved
SebinSong
SebinSong previously approved these changes Jun 15, 2024
Copy link
Collaborator

@SebinSong SebinSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! 👍

@taoeffect taoeffect merged commit 039b500 into master Jun 17, 2024
4 checks passed
@taoeffect taoeffect deleted the logging-tunning-on-backend branch June 17, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants