#2077 - Warn user about char limit in group description #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2409 ↗︎
Details:
Review all test suite changes for PR #2084 ↗︎ |
|||||||||||||||
taoeffect
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2077
Add below character length indication UI to both group-creation Modal and also to
/group-settingspage.-> Group-Creation step
->
GroupSettings.vue@taoeffect @dotmacro
Normally, specifying maxlength HTML attribute to the
textareaelement will prevent user from entering more characters, just like this MDN doc says and how FireFox Dev edition behaves regarding it. But in case there is any browser out there where this is not howmaxlengthattribute behaves, I've added the in-app validation logic to both form so they show this error message when the description becomes longer than 500 characters.Thanks,