Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display app version as well as contracts version #2094

Conversation

Silver-IT
Copy link
Member

@Silver-IT Silver-IT requested a review from taoeffect June 19, 2024 07:05
@Silver-IT Silver-IT self-assigned this Jun 19, 2024
Copy link

cypress bot commented Jun 19, 2024

Passing run #2438 ↗︎

0 106 8 0 Flakiness 0

Details:

Merge 7e50d60 into 8e032da...
Project: group-income Commit: 26f5b2a467 ℹ️
Status: Passed Duration: 09:40 💡
Started: Jun 19, 2024 9:41 PM Ended: Jun 19, 2024 9:51 PM

Review all test suite changes for PR #2094 ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! One minor change request for simplifying the string for translators:

frontend/views/components/tabs/TabWrapper.vue Outdated Show resolved Hide resolved
Copy link
Member Author

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready!

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@taoeffect taoeffect merged commit c060dbd into master Jun 20, 2024
4 checks passed
@taoeffect taoeffect deleted the 2081-display-both-app-version-and-contracts-version-in-the-user-settings-modal branch June 20, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display both app version and contracts version in the user settings modal
2 participants