Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve header style #2095

Merged

Conversation

Silver-IT
Copy link
Member

@Silver-IT Silver-IT requested a review from taoeffect June 19, 2024 12:03
@Silver-IT Silver-IT self-assigned this Jun 19, 2024
@Silver-IT Silver-IT linked an issue Jun 19, 2024 that may be closed by this pull request
Copy link
Member Author

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for the review!

I didn't work on the stuff to display and more... for the following reasons

  • Noticed Slack doesn't display and more inside the greeting message
  • We have 3 same titles; greeting message, channel name, document title. And I am not sure how to update the others too.

Copy link

cypress bot commented Jun 19, 2024

Passing run #2432 ↗︎

0 106 8 0 Flakiness 0

Details:

Merge e9cd658 into 461b76f...
Project: group-income Commit: 58c0f1fac2 ℹ️
Status: Passed Duration: 09:32 💡
Started: Jun 19, 2024 12:05 PM Ended: Jun 19, 2024 12:15 PM

Review all test suite changes for PR #2095 ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Silver-IT !

@taoeffect taoeffect merged commit 8e032da into master Jun 19, 2024
4 checks passed
@taoeffect taoeffect deleted the 2067-fix-the-style-of-direct-message-with-many-members branch June 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the style of direct message with many members
2 participants