Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manifest loading #2116

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix manifest loading #2116

merged 1 commit into from
Jun 24, 2024

Conversation

corrideat
Copy link
Member

No description provided.

@cypress Cypress
Copy link

cypress bot commented Jun 24, 2024 •
edited
Loading

Passing run #2466 ↗︎

0 114 8 0 Flakiness 0

Details:

Merge 256179d into 9a64672...
Project: group-income Commit: 98c5dff48b ℹ️
Status: Passed Duration: 10:20 💡
Started: Jun 24, 2024 8:03 PM Ended: Jun 24, 2024 8:14 PM

Review all test suite changes for PR #2116 ↗︎

taoeffect
taoeffect previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@corrideat
Fix #2103
256179d 
* Fix manifest loading
* Prevent processing events if OP_CONTRACT failed
* Prevent processing subsequent events after an error
  due to missing state
taoeffect
taoeffect approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

(note: this will close #2103 because of the commit message, but not all issues have been fixed. Specifically: Error 5 may still likely be an issue)

@taoeffect taoeffect merged commit 89dc42d into master Jun 24, 2024
4 checks passed
@taoeffect taoeffect deleted the bugfixes branch June 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corrideat @taoeffect