Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2133 #2134

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix #2133 #2134

merged 1 commit into from
Jun 28, 2024

Conversation

corrideat
Copy link
Member

No description provided.

@corrideat corrideat requested a review from taoeffect June 28, 2024 16:55
@corrideat corrideat self-assigned this Jun 28, 2024
Copy link

cypress bot commented Jun 28, 2024

Passing run #2501 ↗︎

0 114 8 0 Flakiness 0

Details:

Merge 5e3954f into 3f9425d...
Project: group-income Commit: 9ea1e99712 ℹ️
Status: Passed Duration: 10:37 💡
Started: Jun 28, 2024 5:17 PM Ended: Jun 28, 2024 5:27 PM

Review all test suite changes for PR #2134 ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @corrideat! Interesting changes - especially with the new queue for 'gi.actions/group/join', but it seems like that apparently might be necessary for some situations, per your comment. Nicely done with the comments 👍

@taoeffect taoeffect merged commit ee99c07 into master Jun 28, 2024
4 checks passed
@taoeffect taoeffect deleted the bugfix/2133-cannot-set-existing-unrevoked-key branch June 28, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants