Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heisenbug while checking payment details #2227

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Fix heisenbug while checking payment details #2227

merged 8 commits into from
Jul 24, 2024

Conversation

Silver-IT
Copy link
Member

@Silver-IT Silver-IT commented Jul 19, 2024 •
edited
Loading

@Silver-IT Silver-IT requested a review from taoeffect July 19, 2024 01:22
@Silver-IT Silver-IT self-assigned this Jul 19, 2024
@Silver-IT Silver-IT linked an issue Jul 19, 2024 that may be closed by this pull request
Heisenbug: group-paying.spec.js modal related bug #2168
Closed
Silver-IT
Silver-IT commented Jul 19, 2024
View reviewed changes
Copy link
Member Author

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for the review!

@Silver-IT Silver-IT mentioned this pull request Jul 19, 2024
Closed
@cypress Cypress
Copy link

cypress bot commented Jul 19, 2024 •
edited
Loading

Passing run #2774 ↗︎

0 112 10 0 Flakiness 0

Details:

Merge b76f617 into 06aabd6...
Project: group-income Commit: f313e0db58 ℹ️
Status: Passed Duration: 12:49 💡
Started: Jul 23, 2024 7:23 AM Ended: Jul 23, 2024 7:36 AM

Review all test suite changes for PR #2227 ↗︎

taoeffect
taoeffect requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this PR is unlikely to close #2168 because it does not appear to touch any code related to that.

@Silver-IT
Copy link
Member Author

As far as I can tell, this PR is unlikely to close #2168 because it does not appear to touch any code related to that.

Actually, it does. The main reason is that the NEW_DISTRIBUTION_PERIOD notification is created just after the select element but before the click event is called. What I did is that make the Cypress to wait until all the notifications are created before select element and click it.

Silver-IT
Silver-IT commented Jul 23, 2024
View reviewed changes
Copy link
Member Author

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for the review!

taoeffect
taoeffect approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's hope this does it! 🤞

@taoeffect taoeffect merged commit 96ce11f into master Jul 24, 2024
4 checks passed
@taoeffect taoeffect deleted the 2168-heisenbug-group-payingspecjs-modal-related-bug branch July 24, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@Silver-IT Silver-IT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated notifications are possibly created in Cypress Heisenbug: group-paying.spec.js modal related bug
2 participants
@Silver-IT @taoeffect