-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heisenbug of group-chat #2231
Merged
taoeffect
merged 10 commits into
master
from
2226-heisenbug-in-group-chatspecjs-more-persistent-one
Jul 23, 2024
Merged
Fix heisenbug of group-chat #2231
taoeffect
merged 10 commits into
master
from
2226-heisenbug-in-group-chatspecjs-more-persistent-one
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2767 ↗︎
Details:
Review all test suite changes for PR #2231 ↗︎ |
… because assert inside then clause?
Silver-IT
commented
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for the review! This is the Chunk 1 of the Issue #2226.
taoeffect
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats @Silver-IT !!!
taoeffect
deleted the
2226-heisenbug-in-group-chatspecjs-more-persistent-one
branch
July 23, 2024 05:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
cy.wait
and makegroup-chat
spec always pass