-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2243 - Fix markdown <code> element issue #2247
Conversation
…de-code-snippet-issue
Passing run #2785 ↗︎
Details:
Review all test suite changes for PR #2247 ↗︎ |
Question, the issue solution section says:
But the screenshot shows the text being wrapped. The reason why I wrote add a horizontal scrollbar is because wrapping text sometimes makes it hard to read source code on a small screen and be able to tell what line is what. Do you think you could update this to use the horizontal scroll bar? |
@taoeffect Updated again with the fix |
@@ -82,6 +82,7 @@ export default ({ | |||
.c-emoticons-list { | |||
padding-left: 3rem; | |||
display: flex; | |||
flex-wrap: wrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really solid - great work @SebinSong !
#2243
[ Fix screenshot ]