Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2243 - Fix markdown <code> element issue #2247

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

SebinSong
Copy link
Collaborator

#2243

[ Fix screenshot ]

@SebinSong SebinSong self-assigned this Jul 23, 2024
Copy link

cypress bot commented Jul 23, 2024

Passing run #2785 ↗︎

0 112 10 0 Flakiness 0

Details:

Merge 4a4dc3e into 06aabd6...
Project: group-income Commit: 4fc16f383e ℹ️
Status: Passed Duration: 10:46 💡
Started: Jul 24, 2024 2:22 AM Ended: Jul 24, 2024 2:33 AM

Review all test suite changes for PR #2247 ↗︎

@taoeffect
Copy link
Member

Question, the issue solution section says:

When text goes beyond that width, a horizontal scrollbar should appear at the bottom of the codeblock (don't wrap the text, in other words)

But the screenshot shows the text being wrapped. The reason why I wrote add a horizontal scrollbar is because wrapping text sometimes makes it hard to read source code on a small screen and be able to tell what line is what. Do you think you could update this to use the horizontal scroll bar?

@SebinSong
Copy link
Collaborator Author

@taoeffect Updated again with the fix

@@ -82,6 +82,7 @@ export default ({
.c-emoticons-list {
padding-left: 3rem;
display: flex;
flex-wrap: wrap;
Copy link
Collaborator Author

@SebinSong SebinSong Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix for the overflowing emoji issues @Silver-IT found.

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really solid - great work @SebinSong !

@taoeffect taoeffect merged commit 6380d4d into master Jul 24, 2024
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2243-wide-code-snippet-issue branch July 24, 2024 03:25
@Silver-IT Silver-IT mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants