#2217 - Add UI limit for chat message #2272
Conversation
|
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
There was a problem hiding this comment.
Nice work @SebinSong!
One issue I found: the UI gets kind of broken in Firefox when I past a very large file. I couldn't even check if the text is being cut off because I'm not able to scroll the page or the input box when it's like this:
Can you maybe add a height limit to the input box itself, and then add a scrollbar that appears so that the contents can be scrolled? (Please verify it also works well on mobile too when a very large amount of text is copy/pasted)
There was a problem hiding this comment.
Nice work @SebinSong, I think this is a good height for mobile:
For desktop, I would make it slightly taller.
However, the most important issue is that still I cannot scroll the input box. Can you? When I try to scroll using the scroll wheel it doesn't work. I would also maybe make a vertical scrollbar visible on the righthand side when the text overflows past the max height.
|
@taoeffect 
|
closes #2217
Currently
CHATROOM_MAX_MESSAGE_LEN = 20000and I've addedmaxlengthattribute for it (which makes sure string beyond that limit gets cut off), but not thatn/20000indicator UI because I thought it will be rare that the user types messages longer than that and having it won't be that useful compared to other places.But let me know if we need it in place here too.