Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2051 - Enhance the logic handling 'Already-joined group' error #2273

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

SebinSong
Copy link
Collaborator

work on #2051

I was able to reproduce the target error via the steps I described in this comment. This PR is to present below screen when that error is encountered. (In the screenshot, the console error saying 'Cannot join already joined group' is correctly mapped to this screen.)

image

@SebinSong SebinSong self-assigned this Jul 30, 2024
@SebinSong SebinSong requested a review from taoeffect July 30, 2024 06:40
Copy link

cypress bot commented Jul 30, 2024



Test summary

112 0 10 0


Run details

Project group-income
Status Passed
Commit b484ebc ℹ️
Started Jul 30, 2024 8:57 AM
Ended Jul 30, 2024 9:08 AM
Duration 10:56 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taoeffect taoeffect merged commit 9eb4aba into master Aug 2, 2024
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2051-issue-with-already-joined-group branch August 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants