Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2220 - add more numberRange / stringMax validators #2274

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

SebinSong
Copy link
Collaborator

closes #2220

I noticed the Remove member modal is missing the n/500 indicator. so added it too.

@SebinSong SebinSong self-assigned this Aug 1, 2024
Copy link

cypress bot commented Aug 1, 2024



Test summary

112 0 10 0


Run details

Project group-income
Status Passed
Commit b259592 ℹ️
Started Aug 1, 2024 3:42 AM
Ended Aug 1, 2024 3:52 AM
Duration 10:36 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@taoeffect taoeffect merged commit 6883ce9 into master Aug 5, 2024
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2220-number-range-validator branch August 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add numberRange() validator + string validation fixes
2 participants