#2283 - Chat should not replace symbols in <code> #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
SebinSong
commented
Aug 8, 2024
Comment on lines
+36
to
+50
| const strSplitByCodeMarkdown = splitStringByMarkdownCode(str) | ||
| strSplitByCodeMarkdown.forEach((entry, index) => { | ||
| if (entry.type === 'plain' && strSplitByCodeMarkdown[index - 1]?.text !== '```') { | ||
| let entryText = entry.text | ||
| entryText = entryText.replace(/</g, '<').replace(/>/g, '>') | ||
|
|
||
| str = str.replace(/\n(?=\n)/g, '\n<br>') | ||
| .replace(/<br>\n(\s*)(\d+\.|-|```)/g, '\n\n$1$2') // custom-handling the case where <br> is directly followed by the start of block-code (```) | ||
| .replace(/(\d+\.|-)(\s.+)\n<br>/g, '$1$2\n\n') // this is a custom-logic added so that the end of ordered/un-ordered lists are correctly detected by markedjs. | ||
| entryText = entryText.replace(/\n(?=\n)/g, '\n<br>') | ||
| .replace(/<br>\n(\s*)(\d+\.|-)/g, '\n\n$1$2') // custom-handling the case where <br> is directly followed by the start of ordered/unordered lists | ||
| .replace(/(\d+\.|-)(\s.+)\n<br>/g, '$1$2\n\n') // this is a custom-logic added so that the end of ordered/un-ordered lists are correctly detected by markedjs. | ||
|
|
||
| entry.text = entryText | ||
| } | ||
| }) | ||
|
|
||
| str = combineMarkdownSegmentListIntoString(strSplitByCodeMarkdown) |
There was a problem hiding this comment.
The cause of the issue was that,
These additional fixes & adjustments related to white-spaces, line-breaks and < and > did not need to be applied to the contents of <code>...</code>.
So a logic added here where it selectively apply these adjustments to the text contents outside of <code>...</code>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2283
[Proof of the fix]