#2158 - Fix the broken 'Reduced-motion' mode #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Aug 22, 2024
| @@ -15,7 +15,7 @@ span.c-twrapper( | |||
|
|
|||
| .c-tooltip( | |||
| :style='styles' | |||
| :class='{"has-text-center": isTextCenter, "is-active": isActive, manual, "is-dark-theme": $store.getters.isDarkTheme}' | |||
| :class='{"has-text-center": isTextCenter, "is-active": isActive, manual, "is-dark-theme": $store.getters.isDarkTheme, "in-reduced-motion": isReducedMotionMode }' | |||
There was a problem hiding this comment.
Tooltip needs a special treatment here because, when it becomes active, it's appended to <body> not the root Vue component (<div id='#app'>)
SebinSong
commented
Aug 22, 2024
| @@ -1,5 +1,5 @@ | |||
| <template lang='pug'> | |||
| .c-message( | |||
| .c-message.force-motion( | |||
There was a problem hiding this comment.
Message highlight animation still needs to happen regardless of reduced-motion setting.
SebinSong
commented
Aug 22, 2024
Comment on lines
+5
to
+6
| *:not(.force-motion)::after, | ||
| *:not(.force-motion)::before { |
There was a problem hiding this comment.
I noticed some animations happen in the ::after, ::before pseudo elements. eg) checkbox, toggle-button.
So took that into account here too.
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
refs/pull/2316/merge
|
| Run status |
|
| Run duration | 10m 53s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
approved these changes
Aug 29, 2024
taoeffect
deleted the
sebin/task/#2158-investigate-reduced-motion-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2158
it appears that this feature was broken when the vuex-state for app-settings was moved to a separate module. So fixed it.
While at it, created a
.force-motioncss class for any part of the app where the animation still needs to happen regardless of the reduced-motion setting.(eg. this highlight animation for
move-to-specific-messagefeature in the chat-room.)Cheers,