Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have timeout eat into reconnect delay #2318

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

corrideat
Copy link
Member

No description provided.

Copy link

cypress bot commented Aug 27, 2024

group-income    Run #2957

Run Properties:  status check passed Passed #2957  •  git commit c9e9a7c837 ℹ️: Merge e7fec88775a012fa9b763a41b676dd50ca96a1a8 into d2a7b75643945aec5a5026a814a4...
Project group-income
Branch Review refs/pull/2318/merge
Run status status check passed Passed #2957
Run duration 10m 46s
Commit git commit c9e9a7c837 ℹ️: Merge e7fec88775a012fa9b763a41b676dd50ca96a1a8 into d2a7b75643945aec5a5026a814a4...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taoeffect taoeffect merged commit 487b086 into master Aug 27, 2024
4 checks passed
@taoeffect taoeffect deleted the bugfix/1943-reconnect-appears-for-too-long branch August 27, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants